Re: [PATCH net 08/14] selftests: net: bridge_vlan_aware: test that other TPIDs are seen as untagged

On Thu, Aug 15, 2024 at 12:11:07PM +0300, Ido Schimmel wrote:

Thanks for the test. Passes with mlxsw as well.

Thanks for testing.

...

• ethtool -K $h2 rx-vlan-filter off rx-vlan-stag-filter off

Any reason not to undo it at the end of the test like other settings?

A combination of laziness to add even more logic to save/restore the ethtool features (should probably live in lib.sh), plus a persistent question of "who cares anyway". The default values are driver defined anyway, so it's likely that anyone who cares will control these features prior to starting their application. Plus, turning off RX VLAN filtering offload should not technically leave anything broken behind.