Re: [PATCH v4 bpf 1/2] bpf: fix skb_do_redirect return values

I'm not a networking person, but I was looking at some use after free static checker warnings.

Apparently the rule with xmit functions is that if they return a value

15 then that means the skb was not freed. Otherwise it's supposed to

be freed. So like NETDEV_TX_BUSY is 0x10 so it's not freed.

This is checked with using the dev_xmit_complete() function. So I feel like it would make sense for LWTUNNEL_XMIT_CONTINUE to return higher than 15.

Because that's the bug right? The original code was assuming that everything besides LWTUNNEL_XMIT_DONE was freed.

regards, dan carpenter