Re: [PATCH 3/5] KVM: selftests: Simplify demand_paging_test with timespec_diff_now

On Tue, Oct 27, 2020 at 04:37:31PM -0700, Ben Gardon wrote:

Add a helper function to get the current time and return the time since a given start time. Use that function to simplify the timekeeping in the demand paging test.

Nit: timespec_diff_now() sounds less charming than timespec_elapsed() to me... "diff_now" is longer, and it also does not show positive/negative of the results (which in this case should always be end-start). "elapsed" should always mean something positive.

With/Without the change above:

Reviewed-by: Peter Xu peterx@redhat.com