Re: [PATCH v12 net-next 08/15] tcp: accecn: add AccECN rx byte counters

n 7/4/25 10:53 AM, chia-yu.chang@nokia-bell-labs.com wrote:

diff --git a/include/net/tcp.h b/include/net/tcp.h index 61b103633da4..0d8e1a676dad 100644 --- a/include/net/tcp.h +++ b/include/net/tcp.h @@ -971,6 +971,9 @@ static inline u32 tcp_rsk_tsval(const struct tcp_request_sock *treq)

• See draft-ietf-tcpm-accurate-ecn for the latest values.

*/ #define TCP_ACCECN_CEP_INIT_OFFSET 5 +#define TCP_ACCECN_E1B_INIT_OFFSET 1 +#define TCP_ACCECN_E0B_INIT_OFFSET 1 +#define TCP_ACCECN_CEB_INIT_OFFSET 0

It looks like the definitions above are not used in this patch. I suggest moving the definition in 'tcp: accecn: AccECN option'

Otherwise the code LGTM, but I still have some doubts WRT the significant increase of the hotpath data.

/P