On 7/24/19 12:45 PM, Joe Lawrence wrote:
On 07/24/2019 12:45 PM, shuah wrote:
On 7/24/19 12:27 AM, Petr Mladek wrote:
On Mon 2019-07-22 10:05:44, Joe Lawrence wrote:
Add a skip() message function that stops the test, logs an explanation, and sets the "skip" return code (4).
Before loading a livepatch self-test kernel module, first verify that we've built and installed it by running a 'modprobe --dry-run'. This should catch a few environment issues, including !CONFIG_LIVEPATCH and !CONFIG_TEST_LIVEPATCH. In these cases, exit gracefully with the new skip() function.
Reported-by: Jiri Benc jbenc@redhat.com Suggested-by: Shuah Khan shuah@kernel.org Signed-off-by: Joe Lawrence joe.lawrence@redhat.com
Reviewed-by: Petr Mladek pmladek@suse.com
Best Regards, Petr
PS: No need to send v4. The missing "to", suggested by Shuah, could get added when pushing the patch into the repo.
I can't make changes to the patch. I can adjust the commit log at times and correct merge conflicts.
I would like to see v4 for this.
We should clarify for which tree this and "[PATCH] selftests/livepatch: push and pop dynamic debug config" would be merged. I had assumed this would go to the livepatching tree, but Shuah, do you prefer that selftest-centric patches go through the selftests tree?
I'm okay with either and can send up a v4 if needed. But also this would be good to know for future changesets like this, we can perhaps mark the destination branch in advance.
I prefer to take these through kselftest tree unless there is a dependency on other trees. It is the case for some feature dependent tests that might have dependency on the feature.
This doesn't appear to have any dependency.
thanks, -- Shuah