Re: [PATCH] selftests: Makefile: add missing 'net/lib' to targets

On Thu, Sep 12, 2024 at 2:31 AM Anders Roxell anders.roxell@linaro.org wrote:

Fixes: 1d0dc857b5d8 ("selftests: drv-net: add checksum tests") Signed-off-by: Anders Roxell anders.roxell@linaro.org

This target is automatically built for targets that depend on it.

See the commit that introduced it, b86761ff6374.

+++ b/tools/testing/selftests/Makefile @@ -116,6 +116,13 @@ TARGETS += zram TARGETS_HOTPLUG = cpu-hotplug TARGETS_HOTPLUG += memory-hotplug

+# Networking tests want the net/lib target, include it automatically +ifneq ($(filter net,$(TARGETS)),) +ifeq ($(filter net/lib,$(TARGETS)),) + INSTALL_DEP_TARGETS := net/lib +endif +endif

If you believe that it needs to be included directly, please expand the commit message with the reasoning.