Re: [PATCH] selftests/powerpc: Rm the unnecessary remove function.

zhangjiao2 zhangjiao2@cmss.chinamobile.com writes:

From: zhang jiao zhangjiao2@cmss.chinamobile.com

Path is not initialized before use, remove the unnecessary remove function.

Signed-off-by: zhang jiao zhangjiao2@cmss.chinamobile.com

tools/testing/selftests/powerpc/mm/tlbie_test.c | 1 - 1 file changed, 1 deletion(-)

diff --git a/tools/testing/selftests/powerpc/mm/tlbie_test.c b/tools/testing/selftests/powerpc/mm/tlbie_test.c index 48344a74b212..fd1456d16a7d 100644 --- a/tools/testing/selftests/powerpc/mm/tlbie_test.c +++ b/tools/testing/selftests/powerpc/mm/tlbie_test.c @@ -314,7 +314,6 @@ static inline void end_verification_log(unsigned int tid, unsigned nr_anamolies) fclose(f); if (nr_anamolies == 0) {

• remove(path);
  

  return; }

Nice catch. Indeed the path is uninitialized here.

However, I believe the above "if" block should come after initializing the path. The idea is if there were no anamolies noted, then we can simply remove the log file and return.

Something like below. Thoughts?

diff --git a/tools/testing/selftests/powerpc/mm/tlbie_test.c b/tools/testing/selftests/powerpc/mm/tlbie_test.c index 48344a74b212..35f0098399cc 100644 --- a/tools/testing/selftests/powerpc/mm/tlbie_test.c +++ b/tools/testing/selftests/powerpc/mm/tlbie_test.c @@ -313,16 +313,16 @@ static inline void end_verification_log(unsigned int tid, unsigned nr_anamolies)

fclose(f);

- if (nr_anamolies == 0) { - remove(path); - return; - } - sprintf(logfile, logfilename, tid); strcpy(path, logdir); strcat(path, separator); strcat(path, logfile);

+ if (nr_anamolies == 0) { + remove(path); + return; + } + printf("Thread %02d chunk has %d corrupted words. For details check %s\n", tid, nr_anamolies, path); }

-ritesh