Re: [PATCH 01/12] selftests/mm: fix uffd-stress unused function warning

On 02.06.23 03:33, John Hubbard wrote:

uffd_minor_feature() was unused. Remove it in order to fix the associated clang build warning.

Signed-off-by: John Hubbard jhubbard@nvidia.com

tools/testing/selftests/mm/uffd-stress.c | 10 ---------- 1 file changed, 10 deletions(-)

diff --git a/tools/testing/selftests/mm/uffd-stress.c b/tools/testing/selftests/mm/uffd-stress.c index f1ad9eef1c3a..995ff13e74c7 100644 --- a/tools/testing/selftests/mm/uffd-stress.c +++ b/tools/testing/selftests/mm/uffd-stress.c @@ -88,16 +88,6 @@ static void uffd_stats_reset(struct uffd_args *args, unsigned long n_cpus) } } -static inline uint64_t uffd_minor_feature(void) -{

• if (test_type == TEST_HUGETLB && map_shared)

• return UFFD_FEATURE_MINOR_HUGETLBFS;
  

• else if (test_type == TEST_SHMEM)

• return UFFD_FEATURE_MINOR_SHMEM;
  

• else

• return 0;
  

-}

• static void *locking_thread(void *arg) { unsigned long cpu = (unsigned long) arg;

Reviewed-by: David Hildenbrand david@redhat.com