On Fri, May 17, 2024 at 09:03:27AM +0800, Hangbin Liu wrote:
Test arp_ndisc_untracked_subnets use tcpdump to filter the unsolicited and untracked na messages. It set -e before calling tcpdump. But if tcpdump filters 0 packet, it will return none zero, and cause the script to exit.
Instead of using slow tcpdump to capture packets, let's using tc rule to filter out the na message.
At the same time, fix function setup_v6 which only needs one parameter. Move all the related helpers from forwarding lib.sh to net lib.sh.
Fixes: 0ea7b0a454ca ("selftests: net: arp_ndisc_untracked_subnets: test for arp_accept and accept_untracked_na") Signed-off-by: Hangbin Liu liuhangbin@gmail.com
I see that, as of writing, the last two runs of this test have succeeded. Which doesn't seem to have occurred since 9th May. So this does seem positive, albeit perhaps a bit too soon to call.
Jakub, is there a way to tell how long a test took to execute? Perhaps it's obvious, but I couldn't see it.
Code changes look good to me.
Reviewed-by: Simon Horman horms@kernel.org