Re: [PATCH] selftests: Add version file to kselftest installation dir

On 5/28/25 18:33, Tianyi Cui wrote:

As titled, adding version file to kselftest installation dir, so the user of the tarball can know which kernel version the tarball belongs to.

Signed-off-by: Tianyi Cui 1997cui@gmail.com

tools/testing/selftests/Makefile | 6 ++++++ 1 file changed, 6 insertions(+)

diff --git a/tools/testing/selftests/Makefile b/tools/testing/selftests/Makefile index a0a6ba47d600..246e9863b45b 100644 --- a/tools/testing/selftests/Makefile +++ b/tools/testing/selftests/Makefile @@ -291,6 +291,12 @@ ifdef INSTALL_PATH $(MAKE) -s --no-print-directory OUTPUT=$$BUILD_TARGET COLLECTION=$$TARGET \ -C $$TARGET emit_tests >> $(TEST_LIST); \ done;

• @if git describe HEAD > /dev/null 2>&1; then \

• git describe HEAD > $(INSTALL_PATH)/VERSION; \
  

• printf "Version saved to $(INSTALL_PATH)/VERSION\n"; \
  

• else \

• printf "Unable to get version from git describe\n"; \
  

• fi else $(error Error: set INSTALL_PATH to use install) endif

Why not use "make kernelrelease" to get the version?

thanks, -- Shuah