5 Nov
2025
5 Nov
'25
8:31 p.m.
On 10/30/25 12:11 PM, Cosmin Ratiu wrote:
+static void +mlx5e_psp_get_stats(struct psp_dev *psd, struct psp_dev_stats *stats) +{
- struct mlx5e_priv *priv = netdev_priv(psd->main_netdev);
- struct mlx5e_psp_stats nstats;
- mlx5e_accel_psp_fs_get_stats_fill(priv, &nstats);
I don't see the point of the intermediate struct mlx5e_psp_stats, this function could query counters directly into stats.
Just because mlx5_fc_query() populates packet and byte counts, but psp_dev_stats required stats only have byte counts for two of the categories.
I'll address the rest of you comments on the respin. Thanks for taking a look.