Re: [PATCH net-next v5 5/7] tun: Extract the vnet handling code

Akihiko Odaki wrote:

The vnet handling code will be reused by tap.

Signed-off-by: Akihiko Odaki akihiko.odaki@daynix.com

MAINTAINERS | 2 +- drivers/net/tun.c | 179 +---------------------------------------------- drivers/net/tun_vnet.h | 184 +++++++++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 187 insertions(+), 178 deletions(-)

-static inline bool tun_legacy_is_little_endian(unsigned int flags) -{

• return !(IS_ENABLED(CONFIG_TUN_VNET_CROSS_LE) &&

•  (flags & TUN_VNET_BE)) &&
  

• virtio_legacy_is_little_endian();
  

-}

+static inline bool tun_vnet_legacy_is_little_endian(unsigned int flags) +{

• return !(IS_ENABLED(CONFIG_TUN_VNET_CROSS_LE) &&

•  (flags & TUN_VNET_BE)) &&
  

• virtio_legacy_is_little_endian();
  

+}

In general LGTM. But why did you rename functions while moving them? Please add an explanation in the commit message for any non obvious changes like that.