Re: [PATCH bpf-next v1 2/3] selftests/bpf: Add socketpair to create_pair to support unix socket

On Thu, Feb 27, 2025 at 11:52:04AM -0800, Cong Wang wrote:

On Wed, Feb 26, 2025 at 09:22:41PM +0800, Jiayuan Chen wrote:

...

Current wrapper function create_pair() is used to create a pair of connected links and returns two fds, but it does not support unix sockets.

Here we introduce socketpair() into create_pair(), which supports creating a pair of unix sockets, since the semantics of the two are the same.

Since it is only for UDS and only has effectively 1 line of code, how about just calling socketpair(AF_UNIX) in your patch 3/3?

Thanks!

Thanks, Cong, I'll expand selftest to cover TCP and UDP, looks like I missed doing those.