Re: [RFC PATCH 30/33] vfio: selftests: Add a script to help with running VFIO selftests

On Mon, Jun 2, 2025 at 4:08 PM Alex Williamson alex.williamson@redhat.com wrote:

On Fri, 23 May 2025 23:30:15 +0000

...

+function add_id() {

• if echo $(echo ${1} | tr : ' ') > ${2}/new_id 2> /dev/null; then
  

•         echo "Added ${1} to ${2}"
  

•         return 0
  

• fi
  

• return 1
  

+}

I'd suggest using the newer driver_override mechanism rather than new_id/remove_id.

Thanks for the tip, I'll include that in the next version.

I appreciate the work here, I think this could be really useful. As Jason notes a few times, I'd also like to see this automatically iterate through all the combinations of options.

Will do.

Maybe we could also think about whether we can define some build environment options to specify devices to use and this could all be run automatically from 'make kselftest'.

That's an interesting idea. Maybe an environment variable that tests will look for and use if they aren't provided with an explicit BDF string on the command line?

export VFIO_SELFTESTS_DEFAULT_BDF=XXXX:YY:ZZ.AA

Thanks for taking a look!