Re: [PATCH] kvm: selftests: Support dirty log initial-all-set test

On 03/03/20 11:00, Zhoujian (jay) wrote:

...

-----Original Message----- From: Paolo Bonzini [mailto:pbonzini@redhat.com] Sent: Tuesday, March 3, 2020 4:54 PM To: Zhoujian (jay) jianjay.zhou@huawei.com; kvm@vger.kernel.org Cc: peterx@redhat.com; shuah@kernel.org; linux-kselftest@vger.kernel.org; linux-kernel@vger.kernel.org; wangxin (U) wangxinxin.wang@huawei.com; Huangweidong (C) weidong.huang@huawei.com; Liujinsong (Paul) liu.jinsong@huawei.com Subject: Re: [PATCH] kvm: selftests: Support dirty log initial-all-set test

On 03/03/20 09:07, Jay Zhou wrote:

...

#ifdef USE_CLEAR_DIRTY_LOG

• if (!kvm_check_cap(KVM_CAP_MANUAL_DIRTY_LOG_PROTECT2)) {

• fprintf(stderr, "KVM_CLEAR_DIRTY_LOG not available, skipping
  

tests\n");

...

• dirty_log_manual_caps =

• kvm_check_cap(KVM_CAP_MANUAL_DIRTY_LOG_PROTECT2);
  

• if (!dirty_log_manual_caps) {

• fprintf(stderr, "KVM_CLEAR_DIRTY_LOG not available, "
  

• 		"skipping tests\n");
  

• exit(KSFT_SKIP);
  

• }
• if (dirty_log_manual_caps != KVM_DIRTY_LOG_MANUAL_CAPS &&

• dirty_log_manual_caps !=
  

KVM_DIRTY_LOG_MANUAL_PROTECT_ENABLE) {

...

• fprintf(stderr, "KVM_CLEAR_DIRTY_LOG not valid caps "
  

• 		"%"PRIu64", skipping tests\n",
  

• 		dirty_log_manual_caps);
  

  exit(KSFT_SKIP); }

#endif

Thanks, instead of this final "if" it should be enough to do

dirty_log_manual_caps &= (KVM_DIRTY_LOG_MANUAL_PROTECT_ENABLE | KVM_DIRTY_LOG_INITIALLY_SET);

Otherwise looks good, I'll test it and eventually apply both patches.

Do I need to resubmit this patch with this modification?

No, thanks.

Paolo