On Wed, 7 Feb 2024 18:42:52 -0800 Jakub Kicinski wrote:
On Tue, 6 Feb 2024 16:27:40 +0100 Paolo Abeni wrote:
The gro self-tests sends the packets to be aggregated with multiple write operations.
When running is slow environment, it's hard to guarantee that the GRO engine will wait for the last packet in an intended train.
The above causes almost deterministic failures in our CI for the 'large' test-case.
Address the issue explicitly ignoring failures for such case in slow environments (KSFT_MACHINE_SLOW==true).
Fixes: 7d1575014a63 ("selftests/net: GRO coalesce test") Signed-off-by: Paolo Abeni pabeni@redhat.com
Note that the fixes tag is there mainly to justify targeting the net tree, and this is aiming at net to hopefully make the test more stable ASAP for both trees.
I experimented with a largish refactory replacing the multiple writes with a single GSO packet, but exhausted by time budget before reaching any good result.
It does make things a lot more stable, but there was still a failure recently:
https://netdev-3.bots.linux.dev/vmksft-net-dbg/results/455661/36-gro-sh/stdo...
:(
Ah, sorry, I missed the v2. That must have been between v1 and v2.