16 Jun
2025
16 Jun
'25
5:52 p.m.
On Mon, 16 Jun 2025 18:18:18 +0200 Matthieu Baerts wrote:
The ALL_TESTS issue is not the end of it either. We use helpers that call stuff indirectly all over the place. defer, in_ns... It would make sense to me to just disable SC2317 in NIPA runs. Or maybe even put it in net/forwarding/.shellcheckrc. Pretty much all those tests are written in a style that will hit these issues.
In this case, I think it would be better to add this .shellcheckrc file in net/forwarding. If you modify NIPA, I don't think people will know what is allowed or not, or what command line to use, no?
Let's do both? I disabled it to NIPA over the weekend.