On 6/30/22 02:46, Maíra Canal wrote:
Considering the current adoption of the KUnit framework, convert the DRM cmdline parser selftest to the KUnit API.
Acked-by: Daniel Latypov dlatypov@google.com Tested-by: David Gow davidgow@google.com Co-developed-by: Arthur Grillo arthur.grillo@usp.br Signed-off-by: Arthur Grillo arthur.grillo@usp.br Signed-off-by: Maíra Canal maira.canal@usp.br
Same comment for patch #1 apply to all the others. I think you need to change the order of these.
[...]
diff --git a/drivers/gpu/drm/tests/drm_cmdline_parser_test.c b/drivers/gpu/drm/tests/drm_cmdline_parser_test.c new file mode 100644 index 000000000000..ca7669350c64 --- /dev/null +++ b/drivers/gpu/drm/tests/drm_cmdline_parser_test.c @@ -0,0 +1,1078 @@ +// SPDX-License-Identifier: GPL-2.0 +/*
- Copyright (c) 2019 Bootlin
I believe is fair for you to add your Copyright here too since the test changed considerably when ported to the KUnit framework API. Same for the other tests.
- */
+#include <kunit/test.h>
Please add a blank line here. And this also applies to all other tests.
+#include <drm/drm_connector.h> +#include <drm/drm_modes.h>
Reviewed-by: Javier Martinez Canillas javierm@redhat.com