On Mon, Jul 04, 2022 at 09:54:31AM +0200, Hans S wrote:
IIUC, with mv88e6xxx, when the port is locked and learning is disabled:
- You do not get miss violation interrupts. Meaning, you can't report
'locked' entries to the bridge driver.
- You do not get aged-out interrupts. Meaning, you can't tell the
bridge driver to remove aged-out entries.
My point is that this should happen regardless if learning is enabled on the bridge driver or not. Just make sure it is always enabled in mv88e6xxx when the port is locked. Learning in the bridge driver itself can be off, thereby eliminating the need to disable learning from link-local packets.
So you suggest that we enable learning in the driver when locking the port and document that learning should be turned off from user space before locking the port?
Yes. Ideally, the bridge driver would reject configurations where learning is enabled and the port is locked, but it might be too late for that. It would be good to add a note in the man page that learning should be disabled when the port is locked to avoid "unlocking" the port by accident.