Re: [PATCH v5 07/14] iommufd/viommu: Add iommufd_viommu_get_vdev_id helper

On Fri, Jan 10, 2025 at 07:07:36AM +0000, Tian, Kevin wrote:

...

From: Nicolin Chen nicolinc@nvidia.com Sent: Wednesday, January 8, 2025 1:10 AM

• xa_lock(&viommu->vdevs);
• xa_for_each(&viommu->vdevs, index, vdev) {

• if (vdev && vdev->dev == dev) {
  

• 	vdev_id = (unsigned long)vdev->id;
  

• 	break;
  

• }
  

• }

Nit. No need to check vdev pointer as commented in last review.

Oh, I missed that. Will drop it.

Reviewed-by: Kevin Tian kevin.tian@intel.com

Thanks Nicolin