Re: [PATCH v2 01/13] iommufd/fault: Add an iommufd_fault_init() helper

On Wed, Dec 11, 2024 at 07:27:40AM +0000, Tian, Kevin wrote:

...

From: Nicolin Chen nicolinc@nvidia.com Sent: Wednesday, December 4, 2024 6:10 AM

+static int iommufd_fault_init(struct iommufd_fault *fault, char *name,

• 	      struct iommufd_ctx *ictx)
  

+{

• struct file *filep;
• int fdno;
• fault->ictx = ictx;

while at it could you move this line behind iommufd_ctx_get(fault->ictx). usually we want the two together.

Sure. Consider it done.

Reviewed-by: Kevin Tian kevin.tian@intel.com

Thanks! Nic