On Tue, Feb 04, 2025 at 03:35:09AM -0800, Breno Leitao wrote:
Move the static buffers from send_msg_no_fragmentation() and send_msg_fragmented() into the netconsole_target structure. This simplifies the code by:
- Eliminating redundant static buffers
- Centralizing buffer management in the target structure
- Reducing memory usage by 1KB (one buffer instead of two)
The buffer in netconsole_target is protected by target_list_lock, maintaining the same synchronization semantics as the original code.
Suggested-by: Jakub Kicinski kuba@kernel.org Signed-off-by: Breno Leitao leitao@debian.org Reviewed-by: Simon Horman horms@kernel.org
Hi Breno,
Unfortunately this series did not apply to net-next cleanly, which trips up the Netdev CI. Could you rebase and repost?
Also, one minor nit below.
drivers/net/netconsole.c | 30 ++++++++++++++++-------------- 1 file changed, 16 insertions(+), 14 deletions(-)
diff --git a/drivers/net/netconsole.c b/drivers/net/netconsole.c index 86ab4a42769a49eebe5dd6f01dafafc6c86ec54f..c1ad54d99438dbd14e8288d39ad6bcc6f8ff5ad1 100644 --- a/drivers/net/netconsole.c +++ b/drivers/net/netconsole.c @@ -123,6 +123,7 @@ struct netconsole_target_stats {
remote_ip (read-write)local_mac (read-only)remote_mac (read-write)
*/
- @buf The buffer used to send the full msg to the network stack
Tooling seems to want this to be "@buf:" rather than "@buf".
Flagged by ./scripts/kernel-doc -none, and W=1 builds.
...