On 7/29/24 08:52, Laura Nao wrote:
Hi Shuah,
On 7/23/24 18:17, Shuah Khan wrote:
On 7/22/24 09:43, Laura Nao wrote:
Consider skipped tests in addition to passed tests when evaluating the overall result of the test suite in the finished() helper.
I am finally with you now. Can you please more information in your short log and commit log.
Isn't this a bug fix? Current logic before this change will report tests failed if there are any skipped tests?
Can you send v2 calling it a fix and explain the problem clearly.
This isn't problem in this patch, but I am concerned about how simply calling tests passed without calling out skipped tests.
This problem could be solved by printing a message at the end of tests for non-zero skipped test conditions to say the coverage could be increased by enabling config options.
thanks, -- Shuah