-----Original Message----- From: Intel-wired-lan intel-wired-lan-bounces@osuosl.org On Behalf Of Stanislav Fomichev Sent: Tuesday, June 10, 2025 7:15 PM To: netdev@vger.kernel.org Cc: davem@davemloft.net; edumazet@google.com; kuba@kernel.org; pabeni@redhat.com; skalluru@marvell.com; manishc@marvell.com; andrew+netdev@lunn.ch; michael.chan@broadcom.com; pavan.chebbi@broadcom.com; ajit.khaparde@broadcom.com; sriharsha.basavapatna@broadcom.com; somnath.kotur@broadcom.com; Nguyen, Anthony L anthony.l.nguyen@intel.com; Kitszel, Przemyslaw przemyslaw.kitszel@intel.com; tariqt@nvidia.com; saeedm@nvidia.com; louis.peens@corigine.com; shshaikh@marvell.com; GR-Linux-NIC- Dev@marvell.com; ecree.xilinx@gmail.com; horms@kernel.org; dsahern@kernel.org; shuah@kernel.org; ruanjinjie@huawei.com; mheib@redhat.com; stfomichev@gmail.com; linux-kernel@vger.kernel.org; intel-wired-lan@lists.osuosl.org; linux-rdma@vger.kernel.org; oss- drivers@corigine.com; linux-net-drivers@amd.com; linux- kselftest@vger.kernel.org; leon@kernel.org Subject: [Intel-wired-lan] [PATCH net-next v3 2/4] net: remove redundant ASSERT_RTNL() in queue setup functions
The existing netdev_ops_assert_locked() already asserts that either the RTNL lock or the per-device lock is held, making the explicit ASSERT_RTNL() redundant.
Cc: Michael Chan michael.chan@broadcom.com Signed-off-by: Stanislav Fomichev stfomichev@gmail.com
Reviewed-by: Aleksandr Loktionov aleksandr.loktionov@intel.com
net/core/dev.c | 2 -- 1 file changed, 2 deletions(-)
diff --git a/net/core/dev.c b/net/core/dev.c index be97c440ecd5..72997636b8ec 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -3179,7 +3179,6 @@ int netif_set_real_num_tx_queues(struct net_device *dev, unsigned int txq)
if (dev->reg_state == NETREG_REGISTERED || dev->reg_state == NETREG_UNREGISTERING) {
ASSERT_RTNL();netdev_ops_assert_locked(dev);
rc = netdev_queue_update_kobjects(dev, dev-
real_num_tx_queues, @@ -3229,7 +3228,6 @@ int
netif_set_real_num_rx_queues(struct net_device *dev, unsigned int rxq) return -EINVAL;
if (dev->reg_state == NETREG_REGISTERED) {
ASSERT_RTNL();netdev_ops_assert_locked(dev);
rc = net_rx_queue_update_kobjects(dev, dev-
real_num_rx_queues,
-- 2.49.0