11 Jul
2024
11 Jul
'24
1:23 a.m.
On Wed, 10 Jul 2024 16:42:04 -0700 Mina Almasry wrote:
+static inline void netmem_set_pp(netmem_ref netmem, struct page_pool *pool) +{
__netmem_clear_lsb(netmem)->pp = pool;+}
Why is all this stuff in the main header? It's really low level. Please put helpers which are only used by the core in a header under net/core/, like net/core/dev.h
Sorry none of those are only used by net/core/*. Pretty much all of these are used by include/net/page_pool/helpers.h, and some have callers in net/core/devmem.c or net/core/skbuff.c
Would you like me to move these pp specific looking ones to include/net/page_pool/netmem.h or something similar?
That's because some things already in helpers have no real business being there either. Why is page_pool_set_pp_info() in helpers.h?