Re: [PATCH 3/4] selftest/vm: support xfail in mremap_test

On 4/14/22 11:15 AM, Sidhartha Kumar wrote:

Use ksft_test_result_xfail for the tests which are expected to fail.

Same Nit about commit log lines.

Signed-off-by: Sidhartha Kumar sidhartha.kumar@oracle.com

tools/testing/selftests/vm/mremap_test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/vm/mremap_test.c b/tools/testing/selftests/vm/mremap_test.c index 98e9cff34aa7..ace9c3596ed7 100644 --- a/tools/testing/selftests/vm/mremap_test.c +++ b/tools/testing/selftests/vm/mremap_test.c @@ -269,7 +269,7 @@ static void run_mremap_test_case(struct test test_case, int *failures, if (remap_time < 0) { if (test_case.expect_failure)

• 	ksft_test_result_pass("%s\n\tExpected mremap failure\n",
  

• 	ksft_test_result_xfail("%s\n\tExpected mremap failure\n",
  		      test_case.name);
  

  else { ksft_test_result_fail("%s\n", test_case.name);

Thank you. Looks good to me.

Reviewed-by: Shuah Khan skhan@linuxfoundation.org

thanks, -- Shuah