Hi, Jakub.
On Fri, Jun 9, 2023 at 2:53 PM Jakub Kicinski kuba@kernel.org wrote:
On Fri, 9 Jun 2023 13:43:22 -0300 Magali Lemes wrote:
diff --git a/tools/testing/selftests/net/tls.c b/tools/testing/selftests/net/tls.c index e699548d4247..0725c60f227c 100644 --- a/tools/testing/selftests/net/tls.c +++ b/tools/testing/selftests/net/tls.c @@ -25,6 +25,8 @@ #define TLS_PAYLOAD_MAX_LEN 16384 #define SOL_TLS 282
+static int fips_enabled = 0;
No need to zero init static variables, but really instead of doing the main() hack you should init this to a return value of a function. And have that function read the value.
struct tls_crypto_info_keys { union { struct tls12_crypto_info_aes_gcm_128 aes128;
@@ -311,6 +317,9 @@ FIXTURE_SETUP(tls) int one = 1; int ret;
if (fips_enabled && variant->fips_non_compliant)return;Eh, let me help you, this should really be part of the SETUP() function but SETUP() doesn't currently handle SKIP(). So you'll need to add this to your series:
May I add your Suggested-by tag to this upcoming patch in this patchset v3?