On 2019-06-13 7:30 a.m., Jon Mason wrote:
On Thu, May 23, 2019 at 04:30:50PM -0600, Logan Gunthorpe wrote:
This is another resend as there has been no feedback since v4. Seems Jon has been MIA this past cycle so hopefully he appears on the list soon.
I've addressed the feedback so far and rebased on the latest kernel and would like this to be considered for merging this cycle.
The only outstanding issue I know of is that it still will not work with IDT hardware, but ntb_transport doesn't work with IDT hardware and there is still no sensible common infrastructure to support ntb_peer_mw_set_trans(). Thus, I decline to consider that complication in this patchset. However, I'll be happy to review work that adds this feature in the future.
Also, as the port number and resource index stuff is a bit complicated, I made a quick out of tree test fixture to ensure it's correct[1]. As an excerise I also wrote some test code[2] using the upcomming KUnit feature.
Sorry for the delay. The patch is now in the ntb-next branch. We've missed window for 5.2, but it will be in the 5.3 pull request (barring last minute comments).
Thanks Jon!
Logan