Re: [PATCH v8 net-next 11/15] tcp: accecn: AccECN option failure handling

On 6/10/25 2:53 PM, chia-yu.chang@nokia-bell-labs.com wrote:

diff --git a/net/ipv4/tcp_output.c b/net/ipv4/tcp_output.c index 3de6641c776e..d7cdc6589a9c 100644 --- a/net/ipv4/tcp_output.c +++ b/net/ipv4/tcp_output.c @@ -1087,6 +1087,7 @@ static unsigned int tcp_syn_options(struct sock *sk, struct sk_buff *skb, /* Simultaneous open SYN/ACK needs AccECN option but not SYN */ if (unlikely((TCP_SKB_CB(skb)->tcp_flags & TCPHDR_ACK) && tcp_ecn_mode_accecn(tp) &&

•      inet_csk(sk)->icsk_retransmits < 2 &&
  sock_net(sk)->ipv4.sysctl_tcp_ecn_option &&
  remaining >= TCPOLEN_ACCECN_BASE)) {
  

  u32 saving = tcp_synack_options_combine_saving(opts);

AFAICS here the AccECN option is allowed even on the first retransmit as opposed of what enforced for synack packets and what stated in the commit message. Why?

Either code change or code/commit message comment needed.

Thanks,

Paolo