Re: [PATCH v2 4/4] iommufd/selftest: Add coverage for IOMMU_DEVICE_GET_HW_INFO ioctl

On Wed, Mar 08, 2023 at 11:53:58PM -0800, Yi Liu wrote:

diff --git a/drivers/iommu/iommufd/iommufd_test.h b/drivers/iommu/iommufd/iommufd_test.h index da1898a9128f..578691602d94 100644 --- a/drivers/iommu/iommufd/iommufd_test.h +++ b/drivers/iommu/iommufd/iommufd_test.h @@ -100,4 +100,19 @@ struct iommu_test_cmd { }; #define IOMMU_TEST_CMD _IO(IOMMUFD_TYPE, IOMMUFD_CMD_BASE + 32) +/* Mock structs for IOMMU_DEVICE_GET_HW_INFO ioctl */ +#define IOMMU_HW_INFO_TYPE_SELFTEST 0xfeedbeef +#define IOMMU_HW_INFO_SELFTEST_REGVAL 0xdeadbeef

+/**

• • struct iommu_hw_info_selftest
• • @flags: Must be set to 0
• • @test_reg: Pass IOMMU_HW_INFO_SELFTEST_REGVAL to user selftest program
• */

Probably don't need the comment, it is misleading

+struct iommu_hw_info_selftest {

struct iommu_test_hw_info

Jason