On 11/06/25 6:09 pm, Mark Brown wrote:
On Wed, Jun 11, 2025 at 05:40:11PM +0530, Dev Jain wrote:
If CONFIG_UPROBES is not set, a merge subtest fails:
...
CONFIG_UPROBES is enabled by CONFIG_UPROBE_EVENTS, which gets enabled by CONFIG_FTRACE. Therefore add this config to selftests/mm/config so that CI systems can include this config in the kernel build. +++ b/tools/testing/selftests/mm/config @@ -8,3 +8,4 @@ CONFIG_GUP_TEST=y CONFIG_TRANSPARENT_HUGEPAGE=y CONFIG_MEM_SOFT_DIRTY=y CONFIG_ANON_VMA_NAME=y +CONFIG_FTRACE=y
If we need UPROBES we should enable UPROBES explicitly, otherwise it looks like we're just randomly enabling FTRACE even though it's not used itself. If it's a dependency for UPROBES and we also enable UPROBES that's a bit more obvious.
Fair point actually; I'll send a v2 if no other objections are there.
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.