Re: [RFC PATCH v3 0/2] selftests/x86: sysret_rip update for FRED system

On Tue, Jan 24, 2023 at 01:37:43PM -0800, H. Peter Anvin wrote:

On January 24, 2023 1:32:14 PM PST, "Li, Xin3" xin3.li@intel.com wrote:

...

...

From: Ammar Faizi ammarfaizi2@gnuweeb.org

This is an RFC patchset v3: sysret_rip test update for Intel FRED architecture.

Xin Li reported sysret_rip test fails at:

    assert(ctx->uc_mcontext.gregs[REG_EFL] ==
           ctx->uc_mcontext.gregs[REG_R11]);

On FRED systems, flags is 0x200a93 and r11 is 0xfeedfacedeadbeef here.

We need to remove or change this assertion, maybe: assert(ctx->uc_mcontext.gregs[REG_EFL] == ctx->uc_mcontext.gregs[REG_R11] || r11_sentinel == ctx->uc_mcontext.gregs[REG_R11]);

This should use check_regs_result() – which is exactly the reason I made that a separate function.

Fixed in v4.