Guys, sorry about that. For some reason when I run sudo make kselftest the colors don't show up, but if I run the test alone, the colors do show up, like this: sudo tools/testing/selftests/net/mptcp/mptcp_join.sh
I've tried sudo TERM=xterm-256color make kselftest ; sudo make kselftest | cat ;
but it didn't work.
Anyway, thanks a lot for the feedback, time and patience :D
Em qui., 13 de fev. de 2025 às 20:31, Bird, Tim Tim.Bird@sony.com escreveu:
-----Original Message----- From: Marcelo Moreira marcelomoreira1905@gmail.com This commit improves the readability of kselftest results by adding ANSI color codes to the [ OK ] and FAIL messages.
Signed-off-by: Marcelo Moreira marcelomoreira1905@gmail.com
tools/testing/selftests/net/mptcp/mptcp_lib.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/testing/selftests/net/mptcp/mptcp_lib.sh b/tools/testing/selftests/net/mptcp/mptcp_lib.sh index 051e289d7967..7b55855ff788 100644 --- a/tools/testing/selftests/net/mptcp/mptcp_lib.sh +++ b/tools/testing/selftests/net/mptcp/mptcp_lib.sh @@ -83,7 +83,7 @@ mptcp_lib_print_err() {
# shellcheck disable=SC2120 # parameters are optional mptcp_lib_pr_ok() {
mptcp_lib_print_ok "[ OK ]${1:+ ${*}}"
mptcp_lib_print_ok "\033[32m[ OK ]\033[0m${1:+ ${*}}"}
This should not be done unconditionally, but based on the controlling and COLOR variables for this library. You should also re-used the existing color print helper function.
IOW, why is this not using MPTCP_LIB_COLOR_GREEN? or the helper function mptcp_lib_print_color()?
mptcp_lib_pr_skip() { @@ -97,7 +97,7 @@ mptcp_lib_pr_fail() { title="IGNO" cmt=" (flaky)" else
title="FAIL"
title="\033[31mFAIL\033[0m"Why not use the helper function and the MPTCP_LIB_COLOR_RED here?
-- Tim