On 4/3/25 9:33 AM, Michal Koutný wrote:
On Sun, Mar 30, 2025 at 05:52:45PM -0400, Waiman Long longman@redhat.com wrote:
The goto statement in sched_partition_write() is not needed. Remove it and rename sched_partition_write()/sched_partition_show() to cpuset_partition_write()/cpuset_partition_show().
Signed-off-by: Waiman Long longman@redhat.com
kernel/cgroup/cpuset.c | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-)
...
Also noticed (here or for the preceding comments&cleanup patch):
--- a/kernel/cgroup/cpuset.c +++ b/kernel/cgroup/cpuset.c @@ -3525,8 +3525,8 @@ static int cpuset_css_online(struct cgroup_subsys_state *css)
- in the default hierarchy where only changes in partition
- will cause repartitioning.
- If the cpuset has the 'sched.partition' flag enabled, simulate
- turning 'sched.partition" off.
- If the cpuset has the 'cpus.partition' flag enabled, simulate
- turning 'cpus.partition" off.
*/
static void cpuset_css_offline(struct cgroup_subsys_state *css)
Next time...
Thanks for catching that. Will fix in a follow up commit.
Cheers, Longman