Hi
On 02/09/2019 11:53, Dave Martin wrote:
On Fri, Aug 30, 2019 at 05:40:42PM +0100, Cristian Marussi wrote:
Hi
On 13/08/2019 17:22, Dave Martin wrote:
On Fri, Aug 02, 2019 at 06:02:49PM +0100, Cristian Marussi wrote:
Hi
this patchset aims to add the initial arch-specific arm64 support to kselftest starting with signals-related test-cases. A common internal test-case layout is proposed which then it is anyway wired-up to the toplevel kselftest Makefile, so that it should be possible at the end to run it on an arm64 target in the usual way with KSFT.
The tests look like a reasonable base overall and something that we can extend later as needed.
There are various minor things that need attention -- see my comments on the individual patches. Apart for some things that can be factored out, I don't think any of it involves redesign.
A few general comments:
Please wrap all commit messages to <= 75 chars, and follow the other guidelines about commit messages in Documentation/process/submitting-patches.rst).
Remember to run scripts/checkpatch.pl on your patches. Currently various issues are reported: they should mostly be trivial to fix. checkpatch does report some false positives, but most of the warnings I see look relevant.
Thanks for the review. I addressed latest issues in V4, published now.
I kept tests verbose (outputting to stderr) as of now. Removed as a whole standalone build/run.
The responses look reasonable, thanks for repost.
I'll take a look.
Ok Thanks...but...
I'm re-posting now a further V5 which is also rebased on arm64/for-next/core and so deals with the conflicts against queued commit:
https://lore.kernel.org/linux-arm-kernel/c1e6aad230658bc175b42d92daeff2e3005... Subject: [PATCH v19 15/15] selftests, arm64: add a selftest for passing tagged pointers to kernel
Differences from v4 are limited to 01/02 and reported in changelog.
Thanks
Cristian
[...]
Cheers ---Dave