Re: [PATCH bpf-next v3 1/2] bpf: Fix bpf_get/setsockopt to tos not take effect when TCP over IPv4 via INET6 API

On Sat, Sep 14, 2024 at 12:32 PM Feng zhou zhoufeng.zf@bytedance.com wrote:

From: Feng Zhou zhoufeng.zf@bytedance.com

when TCP over IPv4 via INET6 API, bpf_get/setsockopt with ipv4 will fail, because sk->sk_family is AF_INET6. With ipv6 will success, not take effect, because inet_csk(sk)->icsk_af_ops is ipv6_mapped and use ip_queue_xmit, inet_sk(sk)->tos.

Bpf_get/setsockopt use sk_is_inet() helper to fix this case.

Signed-off-by: Feng Zhou zhoufeng.zf@bytedance.com

Reviewed-by: Eric Dumazet edumazet@google.com