On Tue, Oct 08, 2019 at 07:42:05PM -0700, Iurii Zaikin wrote:
Note: this patch is intended to be applied against kselftest/test branch: https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git/lo...
KUnit tests for decoding extended 64 bit timestamps.
I'd suggest using "ext4: add kunit test for decoding extended timestamps" as the one-line summary, and we probably don't need anything else.
Signed-off-by: Iurii Zaikin yzaikin@google.com
fs/ext4/Kconfig | 12 +++ fs/ext4/Makefile | 1 + fs/ext4/inode-test.c | 217 +++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 230 insertions(+) create mode 100644 fs/ext4/inode-test.c
diff --git a/fs/ext4/Kconfig b/fs/ext4/Kconfig index cbb5ca830e57..72c26abbce4c 100644 --- a/fs/ext4/Kconfig +++ b/fs/ext4/Kconfig @@ -106,3 +106,15 @@ config EXT4_DEBUG If you select Y here, then you will be able to turn on debugging with a command such as: echo 1 > /sys/module/ext4/parameters/mballoc_debug
+config EXT4_INODE_KUNIT_TEST
- bool "KUnit test for ext4 inode"
- depends on EXT4_FS
- depends on KUNIT
- help
- This builds the ext4 inode sysctl unit test, which runs on boot.
- Tests the encoding correctness of ext4 inode.
- For more information on KUnit and unit tests in general please refer
- to the KUnit documentation in Documentation/dev-tools/kunit/.
Should we perhaps just call the cofnig "EXT4_KUNIT_TESTS"? Right now the only thing we test is timestamp encoding/decoding, but later on we'll be adding other other ext4 uninit tests --- and more ext4 encoding tests is not neceesarily where I would start, since the rest are actually quite straightforward.
(The next set of uninit tests I'm interested in is the ext4's extent_status tree, since that requires minimal amounts of test mocks.)
So we might as well make the config name more general to begin with.
- Ted