Re: [PATCH bpf-next v2 5/9] selftests/bpf: Add selftest for sockmap/hashmap redirection

On 4/11/25 15:17, Jiayuan Chen wrote:

On Fri, Apr 11, 2025 at 01:32:41PM +0200, Michal Luczaj wrote:

...

Test redirection logic. All supported and unsupported redirect combinations are tested for success and failure respectively. ...

• for (r = redirs; r < redirs + ARRAY_SIZE(redirs); r++) {

• enum bpf_attach_type attach_type;
  

• struct test_sockmap_listen *skel;
  

Could we create a new BPF program file, such as test_sockmap_redir.c, instead of reusing existing ones? This file would be specifically dedicated to serving the sockmap_redir.c functionality.

I understand there are already some duplicate programs, but isn’t this exactly the goal of our current work—to make the test examples more comprehensive and cleaner?

Sure, I get your point. I'll do that.

Thanks, Michal