On Fri, 02 Feb 2024, Rae Moar rmoar@google.com wrote:
On Thu, Feb 1, 2024 at 1:06 AM David Gow davidgow@google.com wrote:
If KUnit is built as a module, and it's unloaded, the kunit_bus is not unregistered. This causes an error if it's then re-loaded later, as we try to re-register the bus.
Unregister the bus and root_device on shutdown, if it looks valid.
In addition, be more specific about the value of kunit_bus_device. It is:
- a valid struct device* if the kunit_bus initialised correctly.
- an ERR_PTR if it failed to initialise.
- NULL before initialisation and after shutdown.
Fixes: d03c720e03bd ("kunit: Add APIs for managing devices") Signed-off-by: David Gow davidgow@google.com
Hello,
I have tested this with modules and it looks good to me!
Thanks! -Rae
Reviewed-by: Rae Moar rmoar@google.com
Thanks for the patch and review!
Is this on its way to some v6.8-rc's? The regression in -rc1 is hurting our CI.
Thanks, Jani.