On Mon, May 19, 2025 at 03:28:47PM +0200, David Hildenbrand wrote:
On 16.05.25 20:07, Mark Brown wrote:
On Fri, May 16, 2025 at 04:12:08PM +0200, David Hildenbrand wrote:
[Converting to kselftet_harness]
That'd certainly work, though doing that is more surgery on the test than I personally have the time/enthusiasm for right now.
Same over here.
But probably if we touch it, we should just clean it up right away. Well, if we decide that that is the right cleanup. (you mention something like that in your patch description :)
OTOH there's something to be said for just making incremental improvements in the tests where we can, they tend not to get huge amounts of love in general which means perfect can very much be the enemy of good. If there's some immediate prospect of someone doing a bigger refactoring then that'd be amazing, but if not then it seems useful to make things play better with the automation for now.
I would agree if it would be a handful of small changes.
But here we are already at
1 file changed, 107 insertions(+), 56 deletions(-)
Those are pretty mechanical changes due to the amount of chat from the program rather than a more substantial reconstruction of the logic which is rather more risky for a drive by.