On Mon, 03 Jun 2024 15:00:03 -0400 Aaron Conole wrote:
I agree, this is an issue. BUT I think it might be better to just filter by field type up front. See:
https://github.com/apconole/linux-next-work/commit/7262107de7170d44b6dbf6c5e...
That version I think ends up being much easier to follow. If you want to take it for your series, feel free. If you disagree, maybe there's something I'm not considering about it.
NOTE that version is just a bunch of independent changes that are squashed together. I have a cleaner version.
I can also bundle up the series I have so far and submit, but I didn't want to do that until I got all the pmtu.sh support working. Maybe it makes sense to send it now though. Simon, Jakub - wdyt?
I'd say - hold onto the changes until pmtu.sh works, unless there's *any* reason for a particular patch to go in early, eg: - patch fixes existing bug - someone else needs a patch - ... - a patch which falls under some of the criteria above depends on the patch