Re: [PATCH v7 02/24] mm/gup: factor out duplicate code from four routines

On Thu 21-11-19 00:29:59, John Hubbard wrote:

...

Otherwise this looks fine and might be a worthwhile cleanup to feed Andrew for 5.5 independent of the gut of the changes.

Reviewed-by: Christoph Hellwig hch@lst.de

Thanks for the reviews! Say, it sounds like your view here is that this series should be targeted at 5.6 (not 5.5), is that what you have in mind? And get the preparatory patches (1-9, and maybe even 10-16) into 5.5?

One more note :) If you are going to push pin_user_pages() interfaces (which I'm fine with), it would probably make sense to push also the put_user_pages() -> unpin_user_pages() renaming so that that inconsistency in naming does not exist in the released upstream kernel.

Honza