On Tue, Apr 2, 2019 at 2:45 PM Kees Cook keescook@chromium.org wrote:
On Wed, Mar 6, 2019 at 1:43 PM Tobin C. Harding tobin@kernel.org wrote:
[...] diff --git a/tools/testing/selftests/lib/prime_numbers.sh b/tools/testing/selftests/lib/prime_numbers.sh index 78e7483c8d60..6f782386d897 100755 --- a/tools/testing/selftests/lib/prime_numbers.sh +++ b/tools/testing/selftests/lib/prime_numbers.sh @@ -2,18 +2,17 @@ [...] -if /sbin/modprobe -q prime_numbers selftest=65536; then
Here it is! This conversion loses the "selftest=..." argument to modprobe.
And I think all of these files could be reduced to a single script that did something like:
. $path/kselftest_module.sh
run "strscpy" test_strscpy run "bitmap" test_bitmap run "prime numbers" prime_numbers selftest=65536
and kselftest_module.sh could define a "trap {...} EXIT" to perform the reporting of everything that got run.
Though I guess if we want separate scripts per module, ignore me on this part. :)