29 Aug
2025
29 Aug
'25
10:50 p.m.
On 8/29/25 11:51 AM, Jason Gunthorpe wrote:
On Wed, Aug 27, 2025 at 12:11:40AM -0700, Randy Dunlap wrote:
+/**
- pt_entry_num_contig_lg2() - Number of contiguous items for this leaf entry
- @pts: Entry to query
- Returns the number of contiguous items this leaf entry spans. If the entry is
- Returns:
I think I prefer to leave many of these as is, putting the entire body in a Returns: block seems too weird. I did the ones that seemed to fit that pattern.
Sure, no problem.
Most of these descriptions are entirely talking about the return value since that is the only thing the function does.
- If true the caller use at level 0 pt_install_leaf_entry(PAGE_SHIFT). This is
uses? although it might just be missing a word or two? I can't tell.
- If true the caller can use, at level 0, pt_install_leaf_entry(PAGE_SHIFT).
- This is useful to create optimized paths for common cases of PAGE_SIZE
- mappings.
Ack.
- Otherwise the bit in position pt_table_item_lg2sz() should be set indicating
- that a non-contigous singe item leaf entry is supported. The following
non-contiguousAlso, is that single ? or is "singe" a real word here? (IDK.)
- Otherwise the bit in position pt_table_item_lg2sz() should be set indicating
- that a non-contiguous single item leaf entry is supported. The following
Ack.
thanks.
--
~Randy