On 2023/8/16 14:11, Hangbin Liu wrote:
On Sat, Aug 12, 2023 at 04:40:36PM +0800, Zhengchao Shao wrote:
When run command "ip netns delete client", device link1_1 has been deleted. So, it is no need to delete link1_1 again. Remove it.
Hi Hangbin:
What if the test exit because the cmd execute failed before setting link1_1 to netns client?
Thanks Hangbin
Your consideration is indeed possible. "ip link del link1_1 >/dev/null 2>&1" maybe looks better?
Zhengchao Shao
Signed-off-by: Zhengchao Shao shaozhengchao@huawei.com
.../drivers/net/bonding/bond-arp-interval-causes-panic.sh | 1 - 1 file changed, 1 deletion(-)
diff --git a/tools/testing/selftests/drivers/net/bonding/bond-arp-interval-causes-panic.sh b/tools/testing/selftests/drivers/net/bonding/bond-arp-interval-causes-panic.sh index 71c00bfafbc9..7b2d421f09cf 100755 --- a/tools/testing/selftests/drivers/net/bonding/bond-arp-interval-causes-panic.sh +++ b/tools/testing/selftests/drivers/net/bonding/bond-arp-interval-causes-panic.sh @@ -11,7 +11,6 @@ finish() { ip netns delete server || true ip netns delete client || true
- ip link del link1_1 || true }
trap finish EXIT -- 2.34.1