Re: [PATCH v3 12/15] iommufd: Add kAPI toward external drivers for physical devices

On Sat, Oct 29, 2022 at 03:19:36PM +0800, Baolu Lu wrote:

...

• rc = iommufd_device_do_attach(idev, hwpt, flags);
  

• refcount_dec(&hwpt->obj.users);
  

• if (rc) {
  

• 	/*
  

• 	 * FIXME: Requires the series to return EINVAL for
  

• 	 * incompatible domain attaches.
  

• 	 */
  

• 	if (rc == -EINVAL)
  

• 		continue;
  

• 	goto out_unlock;
  

• }
  

• goto out_unlock;
  

Can the above code be simplified as:

if (rc == -EINVAL)
	continue;
goto out_unlock;

?

Done

Thanks, Jason