On Mon, Nov 18, 2019 at 2:10 PM Luis Chamberlain mcgrof@kernel.org wrote:
On Fri, Nov 15, 2019 at 10:16:10AM +0000, Alan Maguire wrote:
In discussion of how to handle timeouts, it was noted that if sysctl_hung_task_timeout_seconds is exceeded for a kunit test, the test task will be killed and an oops generated. This should suffice as a means of debugging such timeout issues for now.
Hence remove use of sysctl_hung_task_timeout_secs, which has the added benefit of avoiding the need to export that symbol from the core kernel.
Signed-off-by: Alan Maguire alan.maguire@oracle.com Signed-off-by: Knut Omang knut.omang@oracle.com
This seems like a workaround for sysctl_hung_task_timeout_secs not being exported. If true, this can be addressed by creating a symbol namespace (new) and using that namespace on this path.
It is; as discussed on in v3[1]. I don't really feel strongly one way or the other, I can see arguments for either side. Still, I don't want to give Alan the run-around. I think this is the 3rd or 4th time he has tried to address this issue.
[1] https://lore.kernel.org/linux-kselftest/CAFd5g44esDP6WFmkjOiH+my_4iBeqMpFoSc...