On 13 Feb 2024, at 17:21, David Hildenbrand wrote:
On 13.02.24 22:55, Zi Yan wrote:
From: Zi Yan ziy@nvidia.com
Hi all,
File folio supports any order and multi-size THP is upstreamed[1], so both file and anonymous folios can be >0 order. Currently, split_huge_page() only splits a huge page to order-0 pages, but splitting to orders higher than 0 is going to better utilize large folios. In addition, Large Block Sizes in XFS support would benefit from it[2]. This patchset adds support for splitting a large folio to any lower order folios and uses it during file folio truncate operations.
For Patch 6, Hugh did not like my approach to minimize the number of folios for truncate[3]. I would like to get more feedback, especially from FS people, on it to decide whether to keep it or not.
I'm curious, would it make sense to exclude the "more" controversial parts (i.e., patch #6) for now, and focus on the XFS use case only?
Sure. Patch 6 was there to make use of split_huge_page_to_list_to_order(). Now we have multi-size THP and XFS use cases, it can be dropped.
-- Best Regards, Yan, Zi