Re: [PATCH bpf-next v2 10/13] selftests/bpf: rename pseudo headers checksum computation

On 11/15/24 16:33, Stanislav Fomichev wrote:

On 11/14, Alexis Lothoré (eBPF Foundation) wrote:

...

network_helpers.h provides helpers to compute checksum for pseudo headers but no helpers to compute the global checksums.

Before adding those, rename the pseudo header checksum helper to clarify their role.

Same here: let's keep the old names? They are matching the ones we have on the kernel side so it's easy to find them. I do agree that the naming is unfortunate :-( If you prefer, maybe clarify with a doc?

Yeah, I did not really get the meaning of "magic" here, but ok, let's keep the original name to keep it synced with the kernel functions. I'll replace the rename with some doc.