On Thu, Mar 9, 2023 at 2:24 AM Jiri Pirko jiri@resnulli.us wrote:
Wed, Mar 08, 2023 at 03:37:41PM CET, po-hsu.lin@canonical.com wrote:
On Wed, Mar 8, 2023 at 7:41 PM Jiri Pirko jiri@resnulli.us wrote:
Wed, Mar 08, 2023 at 11:21:57AM CET, po-hsu.lin@canonical.com wrote:
On Wed, Mar 8, 2023 at 5:31 PM Jiri Pirko jiri@resnulli.us wrote:
Tue, Mar 07, 2023 at 04:00:30PM CET, po-hsu.lin@canonical.com wrote:
The `devlink -j port show` command output may not contain the "flavour" key, an example from s390x LPAR with Ubuntu 22.10 (5.19.0-37-generic), iproute2-5.15.0: {"port":{"pci/0001:00:00.0/1":{"type":"eth","netdev":"ens301"}, "pci/0001:00:00.0/2":{"type":"eth","netdev":"ens301d1"}, "pci/0002:00:00.0/1":{"type":"eth","netdev":"ens317"}, "pci/0002:00:00.0/2":{"type":"eth","netdev":"ens317d1"}}}
As Jakub wrote, this is odd. Could you debug if kernel sends the flavour attr and if not why? Also, could you try with most recent kernel?
I did a quick check on another s390x LPAR instance which is running with Ubuntu 23.04 (6.1.0-16-generic) iproute2-6.1.0, there is still no "flavour" attribute. $ devlink port show pci/0001:00:00.0/1: type eth netdev ens301 pci/0001:00:00.0/2: type eth netdev ens301d1 pci/0002:00:00.0/1: type eth netdev ens317 pci/0002:00:00.0/2: type eth netdev ens317d1
The behaviour didn't change with iproute2 built from source [1]
Could you paste output of "devlink dev info"? Looks like something might be wrong in the kernel devlink/driver code.
The `devlink dev info` output is empty. The following output is from that Ubuntu 23.04 s390x LPAR, run as root: # devlink dev show pci/0001:00:00.0 pci/0002:00:00.0 # devlink dev show pci/0001:00:00.0 pci/0001:00:00.0 # devlink dev info # devlink dev info pci/0001:00:00.0
Interesting, could you try ethtool -i to get the driver name?
Hi,
Here you go: $ ethtool -i ens301 driver: mlx4_en version: 4.0-0 firmware-version: 2.35.5100 expansion-rom-version: bus-info: 0001:00:00.0 supports-statistics: yes supports-test: yes supports-eeprom-access: no supports-register-dump: no supports-priv-flags: yes
$ ethtool -i ens317 driver: mlx4_en version: 4.0-0 firmware-version: 2.35.5100 expansion-rom-version: bus-info: 0002:00:00.0 supports-statistics: yes supports-test: yes supports-eeprom-access: no supports-register-dump: no supports-priv-flags: yes
HTH
kernel answers: Operation not supported